LuciferYang commented on PR #37648: URL: https://github.com/apache/spark/pull/37648#issuecomment-1229703838
> Removed [WIP], and need @Ngone51 confirm whether there are new comments of #36200. > > And I have a point to discuss: > > There are two `initLevelDB` method in `LevelDBProvider`, one of them is only for testing code and only used by `org.apache.spark.network.shuffle.ShuffleTestAccessor` now, so should we move the test only `initLevelDB` method to `ShuffleTestAccessor`? The implementation of RocksDB will also encounter this issue @Ngone51 @mridulm [7a22aeb](https://github.com/apache/spark/pull/37648/commits/7a22aebf2bb3121ce52bc2c3939d3593e6d21a16) Move `initDB` method used only by test back to `ShuffleTestAccessor` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
