mridulm commented on code in PR #37648:
URL: https://github.com/apache/spark/pull/37648#discussion_r959280415
##########
common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java:
##########
@@ -85,14 +84,6 @@ public static DB initLevelDB(File dbFile, StoreVersion
version, ObjectMapper map
return tmpDb;
}
- @VisibleForTesting
- static DB initLevelDB(File file) throws IOException {
- Options options = new Options();
- options.createIfMissing(true);
- JniDBFactory factory = new JniDBFactory();
- return factory.open(file, options);
- }
-
Review Comment:
This is mainly used for tests, any particular reason to remove it ?
(There is a lack of error handling in this method, and would fail in case of
corruption or other issues - which I believe `YarnShuffleIntegrationSuite` is
leveraging)
##########
common/network-common/pom.xml:
##########
@@ -151,7 +151,6 @@
<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-tags_${scala.binary.version}</artifactId>
- <scope>test</scope>
Review Comment:
`@Private` rather.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
