mridulm commented on code in PR #37648:
URL: https://github.com/apache/spark/pull/37648#discussion_r963271711
##########
resource-managers/yarn/src/test/scala/org/apache/spark/network/shuffle/ShuffleTestAccessor.scala:
##########
@@ -208,9 +208,12 @@ object ShuffleTestAccessor {
}
def reloadRegisteredExecutors(
- dbBackend: DBBackend,
- file: File): ConcurrentMap[ExternalShuffleBlockResolver.AppExecId,
ExecutorShuffleInfo] = {
- val db = DBProvider.initDB(dbBackend, file)
+ dbBackend: DBBackend,
+ file: File,
+ version: StoreVersion,
+ mapper: ObjectMapper)
+ : ConcurrentMap[ExternalShuffleBlockResolver.AppExecId,
ExecutorShuffleInfo] = {
+ val db = DBProvider.initDB(dbBackend, file, version, mapper)
Review Comment:
This is a behavior change for test, right ([this
?](https://github.com/apache/spark/pull/37648#discussion_r959280415))
Essentially, `YarnShuffleIntegrationSuite` would expect it to fail with an
exception and not do error handling (which `initDB` does).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
