mridulm commented on code in PR #37648:
URL: https://github.com/apache/spark/pull/37648#discussion_r964072617
##########
resource-managers/yarn/src/test/scala/org/apache/spark/network/shuffle/ShuffleTestAccessor.scala:
##########
@@ -208,9 +208,12 @@ object ShuffleTestAccessor {
}
def reloadRegisteredExecutors(
- dbBackend: DBBackend,
- file: File): ConcurrentMap[ExternalShuffleBlockResolver.AppExecId,
ExecutorShuffleInfo] = {
- val db = DBProvider.initDB(dbBackend, file)
+ dbBackend: DBBackend,
+ file: File,
+ version: StoreVersion,
+ mapper: ObjectMapper)
+ : ConcurrentMap[ExternalShuffleBlockResolver.AppExecId,
ExecutorShuffleInfo] = {
+ val db = DBProvider.initDB(dbBackend, file, version, mapper)
Review Comment:
@squito or @tgravescs should have more context about this, and comment
better - looking at the test, I would expect this test code path to
additionally test if the DB is missing/invalid/etc and fail in case there is
any issues (due to lack of error handling/fallback in
`LevelDBProvider.initLevelDB`) - which changes with in PR, that no longer
happens; right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
