LuciferYang commented on code in PR #37648:
URL: https://github.com/apache/spark/pull/37648#discussion_r963299931
##########
resource-managers/yarn/src/test/scala/org/apache/spark/network/shuffle/ShuffleTestAccessor.scala:
##########
@@ -208,9 +208,12 @@ object ShuffleTestAccessor {
}
def reloadRegisteredExecutors(
- dbBackend: DBBackend,
- file: File): ConcurrentMap[ExternalShuffleBlockResolver.AppExecId,
ExecutorShuffleInfo] = {
- val db = DBProvider.initDB(dbBackend, file)
+ dbBackend: DBBackend,
+ file: File,
+ version: StoreVersion,
+ mapper: ObjectMapper)
+ : ConcurrentMap[ExternalShuffleBlockResolver.AppExecId,
ExecutorShuffleInfo] = {
+ val db = DBProvider.initDB(dbBackend, file, version, mapper)
Review Comment:
https://github.com/apache/spark/blob/19b1780c4abed984b2223e6bbe7998b32a2ebad8/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnShuffleIntegrationSuite.scala#L155-L170
Do you mean the behavior change is `execStateCopy exists but open failed`?
The original method will throw an exception directly, and the new method will
return a new instance? It seems that the case just to test whether an existing
`execStateCopy` can be loaded again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
