tgravescs commented on code in PR #37826:
URL: https://github.com/apache/spark/pull/37826#discussion_r967392150
##########
common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java:
##########
@@ -85,14 +84,6 @@ public static DB initLevelDB(File dbFile, StoreVersion
version, ObjectMapper map
return tmpDb;
}
- @VisibleForTesting
Review Comment:
I don't remember in this particular case, its called from
YarnShuffleServiceSuite, maybe it was never setup correctly, in which case
maybe it doesn't matter if we change behavior
##########
common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java:
##########
@@ -85,14 +84,6 @@ public static DB initLevelDB(File dbFile, StoreVersion
version, ObjectMapper map
return tmpDb;
}
- @VisibleForTesting
Review Comment:
I don't remember in this particular case, its called from
YarnShuffleServiceSuite, maybe it was never setup correctly, in which case
maybe it doesn't matter and we aren't changing behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
