LuciferYang commented on code in PR #37826:
URL: https://github.com/apache/spark/pull/37826#discussion_r967630119
##########
common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java:
##########
@@ -85,14 +84,6 @@ public static DB initLevelDB(File dbFile, StoreVersion
version, ObjectMapper map
return tmpDb;
}
- @VisibleForTesting
Review Comment:
@mridulm It seems that `LevelDB/RocksDB` diskstore is not always enabled
when `YarnShuffleService` is used
https://github.com/apache/spark/blob/0996a1588feabea0aa3578bd551dcc1a1627eab7/docs/spark-standalone.md?plain=1#L321-L330
the description(`yarn always has this behavior enabled`) in
`spark.shuffle.service.db.enabled` is incorrect, the behavior of
YarnShuffleService is not controlled by this config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
