LuciferYang commented on code in PR #37826: URL: https://github.com/apache/spark/pull/37826#discussion_r967405666
########## common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java: ########## @@ -85,14 +84,6 @@ public static DB initLevelDB(File dbFile, StoreVersion version, ObjectMapper map return tmpDb; } - @VisibleForTesting Review Comment: Yes, I saw that `YarnShuffleServiceSuite ` called it. But I'm a little curious, how does NodeManager set `RecoveryPath `? If not set, will LevelDB not be initialized? Let me investigate it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org