mridulm commented on code in PR #37843:
URL: https://github.com/apache/spark/pull/37843#discussion_r970331132
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##########
@@ -62,8 +61,7 @@ public String build(Expression expr) {
String name = e.name();
switch (name) {
case "IN": {
- List<String> children =
- Arrays.stream(e.children()).map(c ->
build(c)).collect(Collectors.toList());
+ List<String> children = expressionsToStringList(e.children());
Review Comment:
nit: Given this is called only here, by not avoid the subList ? (give start
and end params to `expressionsToStringList`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
