LuciferYang commented on code in PR #37843:
URL: https://github.com/apache/spark/pull/37843#discussion_r970418647
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/V2PredicateSuite.scala:
##########
@@ -287,7 +287,7 @@ class V2PredicateSuite extends SparkFunSuite {
new Predicate("=", Array[Expression](ref("a"), LiteralValue(1,
IntegerType))),
new Predicate("=", Array[Expression](ref("b"), LiteralValue(1,
IntegerType))))
assert(predicate1.equals(predicate2))
- assert(predicate1.references.map(_.describe()).toSeq == Seq("a", "b"))
+ assert(predicate1.references.map(_.describe()).toSeq.sorted == Seq("a",
"b"))
assert(predicate1.describe.equals("(a = 1) OR (b = 1)"))
Review Comment:
@huaxingao already helped to check that order is not important, but some
override in subclass is keep order.
https://github.com/apache/spark/blob/a2304e45d31d3d802a3976b9cd1ea0f72a2d604b/sql/catalyst/src/main/scala/org/apache/spark/sql/connector/expressions/expressions.scala#L109-L111
Personally, I still hope to revert to the previous orderly version ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
