LuciferYang commented on code in PR #37843:
URL: https://github.com/apache/spark/pull/37843#discussion_r970374550
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##########
@@ -62,8 +61,7 @@ public String build(Expression expr) {
String name = e.name();
switch (name) {
case "IN": {
- List<String> children =
- Arrays.stream(e.children()).map(c ->
build(c)).collect(Collectors.toList());
+ List<String> children = expressionsToStringList(e.children());
Review Comment:
But the `.subList` only wraps a `SubList` object and does not trigger
operations such as memory copy, so the performance gap may be small
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
