MaxGekk commented on PR #37916: URL: https://github.com/apache/spark/pull/37916#issuecomment-1249570897
> You seem to assume < 1000 of these. But just this one PR consumes close to a hundred slots" Some time ago, I have counted the total number of exceptions to be ported onto error classes around 800. I don't see any problems to start using 4 digits after 999. > How do we keep the numbering straight for the next n PRs? We have 3 types of errors, actually: parsing, compilation and execution. We could migrate them 1-by-1 using sequential numbers. Otherwise the PR will conflict a lot. > I assume you used some tooling to whip this up so fast. I think it will be faster to manually port the exceptions without any tooling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
