MaxGekk commented on code in PR #37916:
URL: https://github.com/apache/spark/pull/37916#discussion_r974242158
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -2360,7 +2360,10 @@ class AstBuilder extends
SqlBaseParserBaseVisitor[AnyRef] with SQLConfHelper wit
Literal(converter(rawStrippedQualifier))
} catch {
case e: NumberFormatException =>
- throw new ParseException(e.getMessage, ctx)
+ throw new ParseException(
Review Comment:
> we don't have to instantiate the exception instance in a central file if
it's only used once.
Don't think we should make this excuse for such case. Wenchen, the purpose
of the migration on the temporary error classes is to do that with as less
effort as possible. That's why I didn't move the exception to a central file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
