cloud-fan commented on code in PR #37916:
URL: https://github.com/apache/spark/pull/37916#discussion_r974207860
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -2360,7 +2360,10 @@ class AstBuilder extends
SqlBaseParserBaseVisitor[AnyRef] with SQLConfHelper wit
Literal(converter(rawStrippedQualifier))
} catch {
case e: NumberFormatException =>
- throw new ParseException(e.getMessage, ctx)
+ throw new ParseException(
Review Comment:
We should also mention it in readme.md or somewhere: we don't have to
instantiate the exception instance in a central file if it's only used once.
This can also simplify the error migration work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
