HyukjinKwon commented on code in PR #38276:
URL: https://github.com/apache/spark/pull/38276#discussion_r996633113
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -163,6 +164,14 @@ message Sort {
}
}
+// Relation of type [[Deduplicate]] which have duplicate rows removed, could
consider either only
+// the subset of columns or all the columns.
+message Deduplicate {
+ Relation input = 1;
+ repeated string deduplicate_columns = 2;
+ bool isAll = 3;
Review Comment:
should it be isAll or is_all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
