amaliujia commented on code in PR #38276:
URL: https://github.com/apache/spark/pull/38276#discussion_r997476071
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -41,6 +41,7 @@ message Relation {
Aggregate aggregate = 9;
SQL sql = 10;
LocalRelation local_relation = 11;
+ Deduplicate deduplicate = 13;
Review Comment:
12 is take by `Sample` :) https://github.com/apache/spark/pull/38227
This line will cause merge conflict. Whether which PR is in first, it takes
12 and the other takes 13.
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -41,6 +41,7 @@ message Relation {
Aggregate aggregate = 9;
SQL sql = 10;
LocalRelation local_relation = 11;
+ Deduplicate deduplicate = 13;
Review Comment:
12 is take by `Sample` tough that PR is not merged :)
https://github.com/apache/spark/pull/38227
This line will cause merge conflict. Whether which PR is in first, it takes
12 and the other takes 13.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
