amaliujia commented on code in PR #38276:
URL: https://github.com/apache/spark/pull/38276#discussion_r997473877
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -163,6 +164,14 @@ message Sort {
}
}
+// Relation of type [[Deduplicate]] which have duplicate rows removed, could
consider either only
+// the subset of columns or all the columns.
+message Deduplicate {
+ Relation input = 1;
+ repeated string deduplicate_columns = 2;
+ bool is_all = 3;
Review Comment:
It is a nice convenience that users do know want to know the previous schema
of the LogicalPlan but just want to chain a `DISTINCT`. In this case users
leave the backend to resolve it.
Well from another perspective if we want to match existing DataFrame API
(which is `distinct()`) this becomes a necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
