amaliujia commented on code in PR #38276:
URL: https://github.com/apache/spark/pull/38276#discussion_r997483148
##########
connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:
##########
@@ -31,8 +31,11 @@ import
org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
* test cases.
*/
trait SparkConnectPlanTest {
+
+ def getSession(): SparkSession = None.orNull
Review Comment:
This is relevant to the comment above: the `SharedSparkSession` and its base
defines implicit which will cause ambiguity with Catalyst implicit. For current
`SparkConnectProtoSuite`, we cannot let it inherit `SharedSparkSession`.
Meanwhile for the testing purpose on this `Deduplicate` implementation, we need
a session. This is why this PR does some refactoring on the testing suites to
have a separation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
