HyukjinKwon commented on code in PR #38395:
URL: https://github.com/apache/spark/pull/38395#discussion_r1006477093
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -2100,3 +2100,53 @@ object AsOfJoin {
}
}
}
+
+
+/**
+ * A logical plan for summary.
+ */
+case class Summary(
Review Comment:
Ideally it should better have dedicated SQL plan for each operation in
DataFrame. I guess doing the rewrite and conversion in Analyzer is correct
approach by right .. and Spark Connect just has the proto plan for the
dedicated logical plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
