zhengruifeng commented on code in PR #38395: URL: https://github.com/apache/spark/pull/38395#discussion_r1006804374
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ########## @@ -2100,3 +2100,53 @@ object AsOfJoin { } } } + + +/** + * A logical plan for summary. + */ +case class Summary( Review Comment: since `df.summary` had been reimplemented with dataframe operations https://github.com/apache/spark/commit/6a0713a141fa98d83029d8388508cbbc40fd554e, I guess the only difference is that: with a new plan, the analysis can be saved before the job execution; but if there is something wrong in analysis, the exception will not be thrown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org