HyukjinKwon commented on code in PR #38395:
URL: https://github.com/apache/spark/pull/38395#discussion_r1006643428
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -2100,3 +2100,53 @@ object AsOfJoin {
}
}
}
+
+
+/**
+ * A logical plan for summary.
+ */
+case class Summary(
Review Comment:
Maybe we can support them but I suppose it's better to keep them as
exceptions. If most of them are logical plans, it should be easier for other
people to follow the protocol and implement too. That's actually what I talked
w/ @grundprinzip too (correct me if I am wrong)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
