LuciferYang commented on PR #38427: URL: https://github.com/apache/spark/pull/38427#issuecomment-1296364776
> We should stick to maintaining it as immutable to set the right expectations - else future evolution of the code will assume it is fine to mutate it. A little personal thought:the limitation of `immutable.Seq` is caused by Scala version migration, this comes from Scala 2.13, which changes the predefined `Seq` from `scala.collection.Seq` to ``scala.collection.immutable.Seq``, we only promise that it is a `scala.collection.Seq` when using Scala 2.12 now and 2.13 is beta version, so if we agree to explicitly define `Seq` as `scala.collection.Seq` in the API, the things may become simple. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
