LuciferYang commented on PR #38427: URL: https://github.com/apache/spark/pull/38427#issuecomment-1296738349
> @LuciferYang, based on your results - do you think it is better to wrap it with a version specific api ? Returning Seq for both, but relying on different underlying impl for 2.12 vs 2.13 ? This conversion can be done as part of the construction of `FetchBlockRequest` - so limited in scope. > > Thoughts @srowen ? Give more information for this way: convert `ArrayBuffer` to `immutable.Seq` or `immutable.IndexedSeq`, we should use `immutable.ArraySeq.from(buffer)` or immutable.ArraySeq.unsafeWrapArray(buffer.toArray) instead of `buffer.toSeq(buffer.toIndexedSeq)`, `from` and `unsafeWrapArray` will be more efficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
