rahulsmahadev commented on code in PR #38404:
URL: https://github.com/apache/spark/pull/38404#discussion_r1009642168
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -279,14 +282,26 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRef]
with SQLConfHelper wit
overwrite = false,
ifPartitionNotExists)
case table: InsertOverwriteTableContext =>
- val (relation, cols, partition, ifPartitionNotExists) =
visitInsertOverwriteTable(table)
+ val (relation, cols, partition, ifPartitionNotExists, _)
+ = visitInsertOverwriteTable(table)
InsertIntoStatement(
relation,
partition,
cols,
query,
overwrite = true,
ifPartitionNotExists)
+ case table: InsertIntoReplaceWhereContext =>
Review Comment:
```suggestion
case table: InsertIntoReplaceWhereContext =>
OverwriteByExpression.byPosition(relation, query,
replacePredicates)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
