amaliujia commented on code in PR #38586:
URL: https://github.com/apache/spark/pull/38586#discussion_r1018686188
##########
python/pyspark/sql/connect/column.py:
##########
@@ -30,8 +30,8 @@
def _bin_op(
name: str, doc: str = "binary function", reverse: bool = False
-) -> Callable[["ColumnRef", Any], "Expression"]:
- def _(self: "ColumnRef", other: Any) -> "Expression":
+) -> Callable[["Column", Any], "Expression"]:
+ def _(self: "Column", other: Any) -> "Expression":
Review Comment:
This Python `column` is to match the Scala `Column` I believe:
https://github.com/apache/spark/blob/865a3ded2ea1ca86be93df58205882bc509b98cd/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L151
Not sure about it, is PySpark `Column` actually Expression?
##########
python/pyspark/sql/connect/column.py:
##########
@@ -30,8 +30,8 @@
def _bin_op(
name: str, doc: str = "binary function", reverse: bool = False
-) -> Callable[["ColumnRef", Any], "Expression"]:
- def _(self: "ColumnRef", other: Any) -> "Expression":
+) -> Callable[["Column", Any], "Expression"]:
+ def _(self: "Column", other: Any) -> "Expression":
Review Comment:
This Python `column` is to match the Scala `Column` I believe:
https://github.com/apache/spark/blob/865a3ded2ea1ca86be93df58205882bc509b98cd/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L151
Not sure about it, is PySpark `Column` actually `Expression`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
