amaliujia commented on code in PR #38586:
URL: https://github.com/apache/spark/pull/38586#discussion_r1018706220
##########
python/pyspark/sql/connect/column.py:
##########
@@ -30,8 +30,8 @@
def _bin_op(
name: str, doc: str = "binary function", reverse: bool = False
-) -> Callable[["ColumnRef", Any], "Expression"]:
- def _(self: "ColumnRef", other: Any) -> "Expression":
+) -> Callable[["Column", Any], "Expression"]:
+ def _(self: "Column", other: Any) -> "Expression":
Review Comment:
Class comment says the same:
```
class ColumnRef(Expression):
"""Represents a column reference. There is no guarantee that this column
actually exists. In the context of this project, we refer by its name and
treat it as an unresolved attribute. Attributes that have the same fully
qualified name are identical"""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
