amaliujia commented on code in PR #38586:
URL: https://github.com/apache/spark/pull/38586#discussion_r1018709403
##########
python/pyspark/sql/connect/column.py:
##########
@@ -30,8 +30,8 @@
def _bin_op(
name: str, doc: str = "binary function", reverse: bool = False
-) -> Callable[["ColumnRef", Any], "Expression"]:
- def _(self: "ColumnRef", other: Any) -> "Expression":
+) -> Callable[["Column", Any], "Expression"]:
+ def _(self: "Column", other: Any) -> "Expression":
Review Comment:
Ok I guess my question is do we want to match what PySpark is doing? PySpark
pretty much uses `Column` as `Expression`, which is exposed on API surface.
Connect is exposing this `ColumnRef` to the API surface but only meaning for
unresolved attribute reference.
My initial thought for this PR is to at least matching what PySpark is
doing. Rename first, then expand this class to match PySpark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
