dongjoon-hyun commented on code in PR #38683:
URL: https://github.com/apache/spark/pull/38683#discussion_r1027504573
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala:
##########
@@ -275,8 +275,13 @@ object FileSourceStrategy extends Strategy with
PredicateHelper with Logging {
.get.withName(FileFormat.ROW_INDEX)
}
}
+ // SPARK-41151: metadata column is not nullable for file sources,
+ // [[CreateNamedStruct]] is also not nullable.
Review Comment:
One more thing: This is misleading because this is not true in general.
> [[CreateNamedStruct]] is also not nullable.
To be clear in this context, it would be better to mention
`CreateStruct(structColumns)` explicitly instead of saying
`[[CreateNamedStruct]] is also not nullable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
