dongjoon-hyun commented on code in PR #38683:
URL: https://github.com/apache/spark/pull/38683#discussion_r1027573603
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileMetadataStructSuite.scala:
##########
@@ -654,4 +654,19 @@ class FileMetadataStructSuite extends QueryTest with
SharedSparkSession {
}
}
}
+
+ metadataColumnsTest("SPARK-41151: consistent _metadata nullability " +
+ "between analyzed and executed", schema) { (df, _, _) =>
Review Comment:
That's true. We have been unclear about this. Given that the general
principle is to distinguish different sections for readability and we already
use `2-space indentation` for *the method body*, I believe what we need is to
extend the existing rule by removing `when the parameters don't fit in two
lines`.
Mixing some part of the test case name and method body doesn't give us much
readability. More worse, it's not extensible because that eventually leads us
to use two-space indentation and four-space indentation in Case 1 and Case 2.
**Case 1**
```
metadataColumnsTest("SPARK-41151: consistent _metadata nullability " +
"between analyzed and executed", schema) { (df, _, _) =>
```
**Case 2**
```
metadataColumnsTest("SPARK-41151: consistent _metadata nullability " +
"long long long long long long long long long long long long long long "
+
"between analyzed and executed", schema) { (df, _, _) =>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
