HeartSaVioR commented on code in PR #38683:
URL: https://github.com/apache/spark/pull/38683#discussion_r1027545869
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileMetadataStructSuite.scala:
##########
@@ -654,4 +654,19 @@ class FileMetadataStructSuite extends QueryTest with
SharedSparkSession {
}
}
}
+
+ metadataColumnsTest("SPARK-41151: consistent _metadata nullability " +
+ "between analyzed and executed", schema) { (df, _, _) =>
Review Comment:
https://github.com/databricks/scala-style-guide#indent
For method declarations, use 4 space indentation for their parameters and
put each in each line **when the parameters don't fit in two lines**. Return
types can be either on the same line as the last parameter, or start a new line
with 2 space indent.
So the rule of 4 space indentation is for 3+ lines of definition of method.
We don't specifically mention about two lines of definition of method. While
it's not super clear since we don't have strict guideline, but there is a
general rule of spacing `Use 2-space indentation in general.`, which I think it
could apply to cases which don't fall to exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
