zero323 commented on code in PR #38879:
URL: https://github.com/apache/spark/pull/38879#discussion_r1045234180
##########
python/pyspark/sql/connect/plan.py:
##########
@@ -249,6 +280,7 @@ class Project(LogicalPlan):
def __init__(self, child: Optional["LogicalPlan"], *columns:
"ColumnOrName") -> None:
super().__init__(child)
self._raw_columns = list(columns)
+ _all_of(self._raw_columns, ColumnOrName)
Review Comment:
> The problem is that the user surface of Spark Connect can contain lots of
untyped code so if we don't do any checking the user gets horrible error
messages
Wouldn't be that the first thing to address. Also, does it imply that you
want to put this type of checks all over the place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
