zero323 commented on code in PR #38879:
URL: https://github.com/apache/spark/pull/38879#discussion_r1045235889
##########
python/pyspark/sql/connect/plan.py:
##########
@@ -249,6 +280,7 @@ class Project(LogicalPlan):
def __init__(self, child: Optional["LogicalPlan"], *columns:
"ColumnOrName") -> None:
super().__init__(child)
self._raw_columns = list(columns)
+ _all_of(self._raw_columns, ColumnOrName)
Review Comment:
> Hm .. typing instances aren't actually supposed to be used runtime type
checking.
Where we are right with Spark right now it is the case. In 3.10 you can use
union types with `isinstance` and such making most of this code obsolete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
