zhengruifeng commented on code in PR #39296:
URL: https://github.com/apache/spark/pull/39296#discussion_r1059287998
##########
python/pyspark/sql/connect/expressions.py:
##########
@@ -420,6 +420,12 @@ def __repr__(self) -> str:
return f"{self._name}({', '.join([str(arg) for arg in
self._args])})"
+class UnresolvedBinaryFunction(UnresolvedFunction):
Review Comment:
ok, I think it is fine to start with only handling `binary ops with single
character operator -> infix`.
I think we can simply modify the `__repr__` method of `UnresolvedFunction`,
seems unnecessary to add a new class `UnresolvedBinaryFunction`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
