grundprinzip commented on code in PR #39296:
URL: https://github.com/apache/spark/pull/39296#discussion_r1059649687
##########
python/pyspark/sql/connect/expressions.py:
##########
@@ -420,6 +420,12 @@ def __repr__(self) -> str:
return f"{self._name}({', '.join([str(arg) for arg in
self._args])})"
+class UnresolvedBinaryFunction(UnresolvedFunction):
Review Comment:
I added the behavior for infix / prefix notation and fixed the alias
behavior as well. For the remaining simple checks I did it looks good so far
and should get us to a reasonable comparison.
I don't think the goal should be compatibility on this non-api but similar
readability. If we find cases that are unreasonable to fix, we should apply the
change that @HyukjinKwon proposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
