HyukjinKwon commented on code in PR #39296:
URL: https://github.com/apache/spark/pull/39296#discussion_r1059727323
##########
python/pyspark/sql/connect/expressions.py:
##########
@@ -414,6 +414,12 @@ def to_plan(self, session: "SparkConnectClient") ->
proto.Expression:
return fun
def __repr__(self) -> str:
+ # Special handling for certain infix operators that require slightly
+ # different printing.
+ if len(self._args) == 2 and len(self._name) == 1:
Review Comment:
Actually, what about we just whitelist, and make it nicer? For example,
there are only a fixed number of operators (20 ~ 30) that PySpark supports plug
`eqNullSafe`, and very likely we won't add some more about this.
Otherwise, I would just even remove these new logics, and just fix the
doctest with `...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
