LuciferYang commented on code in PR #39385:
URL: https://github.com/apache/spark/pull/39385#discussion_r1061400974
##########
sql/core/src/main/scala/org/apache/spark/status/protobuf/sql/SparkPlanGraphWrapperSerializer.scala:
##########
@@ -53,8 +53,9 @@ class SparkPlanGraphWrapperSerializer extends ProtobufSerDe {
StoreTypes.SparkPlanGraphNodeWrapper = {
val builder = StoreTypes.SparkPlanGraphNodeWrapper.newBuilder()
- builder.setNode(serializeSparkPlanGraphNode(input.node))
- builder.setCluster(serializeSparkPlanGraphClusterWrapper(input.cluster))
+ Option(input.node).foreach(node =>
builder.setNode(serializeSparkPlanGraphNode(node)))
Review Comment:
Fix the following test in `SQLAppStatusListenerWithRocksDBBackendSuite`:
- `basic`
- `onExecutionEnd happens before onJobEnd(JobSucceeded)`
- `onExecutionEnd happens before multiple onJobEnd(JobSucceeded)s`
- `onExecutionEnd happens before onJobEnd(JobFailed)`
- `onJobStart happens after onExecutionEnd shouldn't overwrite kvstore`
- `handle one execution with multiple jobs`
- `SPARK-32615,SPARK-33016: SQLMetrics validation after sparkPlanInfo
updated in AQE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
