LuciferYang commented on code in PR #39385:
URL: https://github.com/apache/spark/pull/39385#discussion_r1061409595
##########
core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto:
##########
@@ -395,7 +395,8 @@ message SQLExecutionUIData {
optional string error_message = 9;
map<int64, JobExecutionStatus> jobs = 10;
repeated int64 stages = 11;
- map<int64, string> metric_values = 12;
+ bool metric_values_is_null = 12;
Review Comment:
Refer to
https://github.com/apache/spark/blob/23e3c9b7c2f08c5350992934cf660de6d2793982/sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusStore.scala#L98-L104
We should distinguish between `null map` and `empty map`, otherwise
`metricValues` will not be calculated or will be repeatedly calculated
https://github.com/apache/spark/blob/23e3c9b7c2f08c5350992934cf660de6d2793982/sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusStore.scala#L65-L82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
