amaliujia commented on code in PR #39361:
URL: https://github.com/apache/spark/pull/39361#discussion_r1063663717
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -18,14 +18,15 @@ package org.apache.spark.sql.connect.config
import org.apache.spark.internal.config.ConfigBuilder
import org.apache.spark.network.util.ByteUnit
+import org.apache.spark.sql.connect.common.config.ConnectCommon
private[spark] object Connect {
val CONNECT_GRPC_BINDING_PORT =
ConfigBuilder("spark.connect.grpc.binding.port")
.version("3.4.0")
.intConf
- .createWithDefault(15002)
+ .createWithDefault(ConnectCommon.CONNECT_GRPC_BINDING_PORT)
Review Comment:
This matches with Python client side that Python client cannot share any
configs from Spark thus it set the port by it own way.
From this perspective though that this port arg can stay within `client` but
not in `common` because server will use the config and `client` is the only one
use it.
We can stay on this way for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
