amaliujia commented on code in PR #39361:
URL: https://github.com/apache/spark/pull/39361#discussion_r1063670851
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -52,6 +53,12 @@
<version>${protobuf.version}</version>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>${guava.version}</version>
+ <scope>compile</scope>
+ </dependency>
Review Comment:
I am not that familiar with pom so maybe a question:
The common pom include the guava as well without shading it (if I am not
wrong on this), so why add guava to client? client depends on common will get
the guava it needs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
