vicennial commented on code in PR #39361:
URL: https://github.com/apache/spark/pull/39361#discussion_r1064217874
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -52,6 +53,12 @@
<version>${protobuf.version}</version>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>${guava.version}</version>
+ <scope>compile</scope>
+ </dependency>
Review Comment:
Great question. This is a workaround to a pre-existing SBT issue where the
resolution from the imported maven build for particular packages doesn't work
for an unknown reason. This affects Spark-Connect-related projects (see
[here](https://github.com/apache/spark/blob/6cae6aa5156655c79eb3f20292ccec6c479c3b1b/project/SparkBuild.scala#L667-L668)
and
[here](https://github.com/apache/spark/blob/6cae6aa5156655c79eb3f20292ccec6c479c3b1b/project/SparkBuild.scala#L902-L904)
for example).
The pom build works fine when removing the explicit guava dep (as well as
the guava exclusion from the connect-common dep) but the sbt build then fails.
Thus, we explicitly mention the guava version so that SBT can then parse the
version to manually include it (and it's also added as a dep in maven to ensure
version consistency with sbt)
Since the issue affects multiple projects, what do you think about
addressing them at once in a separate bug-fix ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
