tedyu commented on code in PR #39611:
URL: https://github.com/apache/spark/pull/39611#discussion_r1071607092
##########
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java:
##########
@@ -341,6 +343,35 @@ public void testBlockTransferFailureAfterSasl() throws
IOException, InterruptedE
assert(_retryingBlockTransferor.getRetryCount() == 1);
}
+ @Test
+ public void testIOExceptionFailsConnectionEvenWithSaslException()
+ throws IOException, InterruptedException {
+ BlockFetchingListener listener = mock(BlockFetchingListener.class);
+
+ SaslTimeoutException saslExceptionInitial = new
SaslTimeoutException("initial",
+ new TimeoutException());
+ SaslTimeoutException saslExceptionFinal = new SaslTimeoutException("final",
+ new TimeoutException());
+ IOException ioException = new IOException();
+ List<? extends Map<String, Object>> interactions = Arrays.asList(
+ ImmutableMap.of("b0", saslExceptionInitial),
+ ImmutableMap.of("b0", ioException),
+ ImmutableMap.of("b0", saslExceptionInitial),
+ ImmutableMap.of("b0", ioException),
+ ImmutableMap.of("b0", saslExceptionFinal),
+ // will not get invoked
Review Comment:
See if my addition should be enhanced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
