akpatnam25 commented on code in PR #39611:
URL: https://github.com/apache/spark/pull/39611#discussion_r1071689669
##########
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java:
##########
@@ -341,6 +343,35 @@ public void testBlockTransferFailureAfterSasl() throws
IOException, InterruptedE
assert(_retryingBlockTransferor.getRetryCount() == 1);
}
+ @Test
+ public void testIOExceptionFailsConnectionEvenWithSaslException()
Review Comment:
makes sense. I had a similar idea here:
https://github.com/apache/spark/pull/38959/commits/3440f1259e7a04ac0f38ece8b1ce69a9253d43b7
But we ended up opting to go with a simple flag for now. I agree with using
a map in the future where we might have retry counts for each type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
