tedyu commented on code in PR #39611:
URL: https://github.com/apache/spark/pull/39611#discussion_r1071606975
##########
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java:
##########
@@ -341,6 +343,35 @@ public void testBlockTransferFailureAfterSasl() throws
IOException, InterruptedE
assert(_retryingBlockTransferor.getRetryCount() == 1);
}
+ @Test
+ public void testIOExceptionFailsConnectionEvenWithSaslException()
Review Comment:
See the change w.r.t. your 3rd comment.
With that change, I think we don't need to expose `saslRetryCount`.
In the future, we can use a map (type of exception -> outstanding retry
count for that type) where we can think more about asserting on retry count for
each type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
