zhenlineo commented on code in PR #39712:
URL: https://github.com/apache/spark/pull/39712#discussion_r1086093964
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -75,6 +76,13 @@
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
+ <!-- Use mima to perform the compatibility check -->
Review Comment:
The SBT MiMa check has some limitations to run as a SBT rule:
It is the best for a stable API. e.g. current vs previous. It is not very
friendly to configure to test e.g. scala-client vs sql while we are actively
working on the scala-client API.
To be more specific, the problems I hit were:
1. I cannot configure the MiMa rule to find the current SQL SNAPSHOT jar.
2. I cannot use ClassLoader correctly in the SBT rule to load all methods in
the client API.
As a result, I end up this test where we have more freedom to grow the API
test coverage with the client API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
