LuciferYang commented on code in PR #39712:
URL: https://github.com/apache/spark/pull/39712#discussion_r1087799830
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Column.scala:
##########
@@ -80,7 +81,7 @@ class Column private[sql] (private[sql] val expr:
proto.Expression) {
}
}
-object Column {
+private[sql] object Column {
Review Comment:
Both `Column` and `Column$` are `private[sql]` access scope with this pr, so
this is not an API for users?
Seem users cannot create a `Column` in their own package with this pr, for
example:
```scala
package org.apache.spark.test
import org.scalatest.funsuite.AnyFunSuite // scalastyle:ignore funsuite
import org.apache.spark.sql.Column
class MyTestSuite
extends AnyFunSuite // scalastyle:ignore funsuite
{
test("new column") {
val a = Column("a") // Symbol apply is inaccessible from this place
val b = new Column(null) // No constructor accessible from here
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
