zhenlineo commented on code in PR #39712:
URL: https://github.com/apache/spark/pull/39712#discussion_r1087121287


##########
connector/connect/client/jvm/pom.xml:
##########
@@ -75,6 +76,13 @@
       <artifactId>mockito-core</artifactId>
       <scope>test</scope>
     </dependency>
+    <!-- Use mima to perform the compatibility check -->

Review Comment:
   You can check out the MiMa SBT impl I did here: 
https://github.com/zhenlineo/spark/pull/6
   I marked the two problems in the PR code. Unless we can fix the two 
problems. I do not feel it is a better solution than this PR: calling MiMa 
directly in a test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to