LuciferYang commented on code in PR #39789:
URL: https://github.com/apache/spark/pull/39789#discussion_r1092788710
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -105,11 +105,16 @@
<artifactSet>
<includes>
<include>com.google.guava:*</include>
+ <include>io.grpc:*:</include>
Review Comment:
More, I checked the packaging results of the `connect/server` module, It is
no longer correct, many packages have not been relocated to `org.sparkproject`
package.
I reset the code to [[SPARK-40677][CONNECT][FOLLOWUP] Refactor shade
`relocation/rename` rules](https://github.com/apache/spark/pull/38162) and
re-checked the packaging results of the `connect/server` module, It's right on
that snapshot, all shaded packages are relocated to `org.sparkproject` package.
I'm not sure what changed the packaging results of `server` module, but I
think we need to investigate and fix the maven shaded configuration of the
`server` modules to ensure that all the shaded packages are relocated to
`org.sparkproject` package, I will create a new Jira to tracking this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
