LuciferYang commented on code in PR #39789:
URL: https://github.com/apache/spark/pull/39789#discussion_r1092862409


##########
connector/connect/client/jvm/pom.xml:
##########
@@ -132,6 +140,10 @@
               </includes>
             </relocation>
           </relocations>
+          <!--SPARK-42228: Add `ServicesResourceTransformer` to relocation 
class names in META-INF/services for grpc-->

Review Comment:
   **Before**
   
   ```
   ls META-INF/services 
   io.grpc.LoadBalancerProvider io.grpc.ManagedChannelProvider  
io.grpc.NameResolverProvider    io.grpc.ServerProvider
   
   cat META-INF/services/*
   io.grpc.internal.PickFirstLoadBalancerProvider
   io.grpc.util.SecretRoundRobinLoadBalancerProvider$Provider
   io.grpc.netty.NettyChannelProvider
   io.grpc.netty.UdsNettyChannelProvider
   io.grpc.netty.UdsNameResolverProvider
   io.grpc.netty.NettyServerProvider
   ```
   
   **After**
   
   ```
   ls META-INF/services/ 
   org.sparkproject.connect.grpc.LoadBalancerProvider   
org.sparkproject.connect.grpc.NameResolverProvider
   org.sparkproject.connect.grpc.ManagedChannelProvider 
org.sparkproject.connect.grpc.ServerProvider
   
   cat META-INF/services/*
   org.sparkproject.connect.grpc.internal.PickFirstLoadBalancerProvider
   
org.sparkproject.connect.grpc.util.SecretRoundRobinLoadBalancerProvider$Provider
   
org.sparkproject.connect.grpc.protobuf.services.internal.HealthCheckingRoundRobinLoadBalancerProvider
   org.sparkproject.connect.grpc.netty.NettyChannelProvider
   org.sparkproject.connect.grpc.netty.UdsNettyChannelProvider
   org.sparkproject.connect.grpc.netty.UdsNameResolverProvider
   org.sparkproject.connect.grpc.internal.DnsNameResolverProvider
   org.sparkproject.connect.grpc.netty.NettyServerProvider
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to