LuciferYang commented on code in PR #39789:
URL: https://github.com/apache/spark/pull/39789#discussion_r1092870964


##########
connector/connect/client/jvm/pom.xml:
##########
@@ -105,11 +105,19 @@
           <artifactSet>
             <includes>
               <include>com.google.guava:*</include>
+              <include>io.grpc:*</include>
               <include>com.google.protobuf:*</include>
               
<include>org.apache.spark:spark-connect-common_${scala.binary.version}</include>
             </includes>
           </artifactSet>
           <relocations>
+            <relocation>

Review Comment:
   After 
   
   ```
   ls org/sparkproject/connect/client
   grpc guava
   
   ls org/sparkproject/connect/client/grpc
   Attributes$1.class                                                   
LoadBalancer$Helper.class
   Attributes$Builder.class                                             
LoadBalancer$PickResult.class
   Attributes$Key.class                                                 
LoadBalancer$PickSubchannelArgs.class
   Attributes.class                                                     
LoadBalancer$ResolvedAddresses$Builder.class
   BinaryLog.class                                                              
LoadBalancer$ResolvedAddresses.class
   BindableService.class                                                        
LoadBalancer$Subchannel.class
   CallCredentials$MetadataApplier.class                                        
LoadBalancer$SubchannelPicker.class
   CallCredentials$RequestInfo.class                                    
LoadBalancer$SubchannelStateListener.class
   CallCredentials.class                                                        
LoadBalancer.class
   CallOptions$Key.class                                                        
LoadBalancerProvider$UnknownConfig.class
   ....
   ```
   
   all grpc java class relocation to `org/sparkproject/connect/client/grpc`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to