gengliangwang commented on code in PR #40679:
URL: https://github.com/apache/spark/pull/40679#discussion_r1159056715
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala:
##########
@@ -61,6 +61,11 @@ class TableAlreadyExistsException(errorClass: String,
messageParameters: Map[Str
this(errorClass = "TABLE_OR_VIEW_ALREADY_EXISTS",
messageParameters = Map("relationName" -> quoteNameParts(table)))
}
+
+ def this(tableIdent: Identifier) = {
Review Comment:
Nit: let's also add a one-line comment saying this is for backward
compatibility and it is used by external connectors. Otherwise, developers may
remove it again after finding it is not used in Spark.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NoSuchItemException.scala:
##########
@@ -60,6 +60,11 @@ class NoSuchTableException(errorClass: String,
messageParameters: Map[String, St
this(errorClass = "TABLE_OR_VIEW_NOT_FOUND",
messageParameters = Map("relationName" -> quoteNameParts(name)))
}
+
+ def this(tableIdent: Identifier) = {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
